fix(@ngtools/webpack): use outDir for i18n extraction in Angular v5 #7702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
previously approved these changes
Sep 15, 2017
|
LGTM, can confirm it works on the beta.7 a project. Thanks for fixing this @ocombe 👍 |
Brocco
approved these changes
Sep 15, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Angular v5 beta 7, the extraction script uses the new pipeline and genDir has been replaced by outDir. This fix ensures the compatibility with previous versions of Angular as well, which is why I haven't renamed the plugin parameter genDir to outDir (genDir was never related to the "genDir" option from the tsconfig file anyway since it uses the value from the cli parameter
outputPathinstead, or the app config root value by default).Fixes angular/angular#19198